Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base class for Geometry and BufferGeometry with common properties #67

Open
trusktr opened this issue Jun 13, 2020 · 1 comment
Open

Base class for Geometry and BufferGeometry with common properties #67

trusktr opened this issue Jun 13, 2020 · 1 comment
Assignees
@corruptedzulu

Comments

@trusktr
Copy link
Member

trusktr commented Jun 13, 2020 •
edited

Create base class for Geometry and BufferGeometry, inheriting from EventDispatcher. Move id, uuid, name, type to the base class.

This might be applicable to any other classes that also have fields like id, type, name, etc.
@trusktr trusktr created this issue from a note in Initial Port (To do) Jun 13, 2020
@trusktr trusktr moved this from To do to Review in progress in Initial Port Nov 23, 2020
@trusktr
Copy link
Member Author

trusktr commented Nov 23, 2020

We don't necessarily need this for the demo. Removing it from the initial port project. We can make improvements later.

@trusktr trusktr removed this from Review in progress in Initial Port Nov 23, 2020
@trusktr trusktr changed the title Create base class for Geometry and BufferGeometry, inheriting from EventDispatcher. Move id, uuid, name, type to the base class Base class for Geometry and BufferGeometry with common properties Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corruptedzulu corruptedzulu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trusktr @corruptedzulu