Safeguard meta.html fileExists for error-free build on Windows #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #166.
Thanks for an amazing theme! This PR introduces a simple nil check with
{{ with $image_path }}
in meta.html before the call tofileExists $image_path_local
.This change fixes the build issues on Windows machines as described in #166 and #148, as the build will no longer reach a
fileExists
call with a"\assets\%!s(<nil>)"
argument, which is not a supported file path on Windows due to the percent sign.