-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding types for webpack-messages
#6
Comments
Sounds great! You can get a PR started with what you have & I'll likely edit the branch directly to conform to my typical definitions style Thanks~! |
Brilliant, will do. Shout-out to @sndrs for suggesting we push our definition upstream. |
@mxdvl Since it seems the repo is kinda unresponsive, would it be possible to add your work to DefinitelyTyped? I used your workaround from the first post for the time being, but being more programatic is always better, of course. (Also great job on the code from what I can tell) |
Actually, I'd rather not have to maintain the DefinitelyTyped packages. I've proposed this because I needed to solve a problem for my team but Webpack plugins are neither my expertise nor passion. Anyone may reuse these definitions freely without a need for attribution of any kind. |
Thanks for this library, @lukeed.
When looking at converting Webpack configurations to Typescript, I discovered that they were no type declarations for this package. I’ve taken the time to create a declaration for our internal use, but would love to share these with others. Several ways forward are possible, and I would love to have your thoughts on which works best for you:
you don’t want to hear about Typescript, and I’ll raise a DefinitelyTyped package on my own. I’m happy with that option too!The text was updated successfully, but these errors were encountered: