Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding types for webpack-messages #6

Open
mxdvl opened this issue Feb 20, 2022 · 4 comments
Open

Adding types for webpack-messages #6

mxdvl opened this issue Feb 20, 2022 · 4 comments

Comments

@mxdvl
Copy link

mxdvl commented Feb 20, 2022

Thanks for this library, @lukeed.

When looking at converting Webpack configurations to Typescript, I discovered that they were no type declarations for this package. I’ve taken the time to create a declaration for our internal use, but would love to share these with others. Several ways forward are possible, and I would love to have your thoughts on which works best for you:

  1. use JSDoc type declarations into this package. I’ve already created a fork with them
  2. only bring the type declaration as a one-off into this package. I’ve already created a fork with it.
  3. convert this project to typescript. I’ve created a fork for that, too, but you may have no interest to maintain a TS codebase
  4. you don’t want to hear about Typescript, and I’ll raise a DefinitelyTyped package on my own. I’m happy with that option too!
@lukeed
Copy link
Owner

lukeed commented Feb 22, 2022

Sounds great! You can get a PR started with what you have & I'll likely edit the branch directly to conform to my typical definitions style

Thanks~!

@mxdvl
Copy link
Author

mxdvl commented Feb 22, 2022

Brilliant, will do.

Shout-out to @sndrs for suggesting we push our definition upstream.

@mxdvl mxdvl mentioned this issue Feb 24, 2022
@Nya-chan
Copy link

@mxdvl Since it seems the repo is kinda unresponsive, would it be possible to add your work to DefinitelyTyped? I used your workaround from the first post for the time being, but being more programatic is always better, of course.

(Also great job on the code from what I can tell)

@mxdvl
Copy link
Author

mxdvl commented Jul 5, 2023

Actually, I'd rather not have to maintain the DefinitelyTyped packages. I've proposed this because I needed to solve a problem for my team but Webpack plugins are neither my expertise nor passion.

Anyone may reuse these definitions freely without a need for attribution of any kind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants