Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sh plugin : Windows Containers #9

Open
solvingj opened this issue Jun 5, 2019 · 3 comments
Open

sh plugin : Windows Containers #9

solvingj opened this issue Jun 5, 2019 · 3 comments

Comments

@solvingj
Copy link

solvingj commented Jun 5, 2019

There's another operating system called "Microsoft Windows", which also supports docker and containers, but it has two different native shells referred to as command prompt and powershell, and it also supports bash if it is installed.

A more general plugin could be called "shell" and support any type of container, do you think that's possible?

I guess it's unlikely to be supported here since you actually wrote the plugins in bash, rather than a cross-platform language. Is that accurate?

@lukaszlach
Copy link
Owner

This is a valid issue, I'd test how to extend the "sh" plugin to support Windows shells as well.

@solvingj
Copy link
Author

solvingj commented Jun 6, 2019

Wow, that's great news, I really think docker cli plugins are exciting, and you're definitely pioneering bigtime. Thanks to you, I have a few ideas for plugins if I ever find the time.

@solvingj
Copy link
Author

solvingj commented Jun 20, 2019

Of note, Jenkins CI platform has sh and bat functions, which support linux and windows hosts respectively. The approach of having two separate functions has a major issue with many complaints and feature requests surrounding it. While many things about sh and bat (and posh) syntax are incompatible, many common use cases are compatible. For example, any native binary call, like go xyz or java xyz or python xyz.

It's really frustrating on Jenkins that there's no generic 'command' function which will pass a command through to the default shell for both windows or linux hosts. So, it's not simple to define a job that can run equally well on windows or linux agents, users have to define conditional logic which is ugly. I don't know if that will be relevant in this case, but it might.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants