Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code breaks when I upgrade my angular from 8.0 to 9.0 #309

Open
ashismo opened this issue Apr 8, 2020 · 7 comments
Open

Code breaks when I upgrade my angular from 8.0 to 9.0 #309

ashismo opened this issue Apr 8, 2020 · 7 comments

Comments

@ashismo
Copy link

ashismo commented Apr 8, 2020

When I upgraded my angular from 8.0 to 9.0, getting the below error. Can you please fix this?
ERROR in node_modules/ngx-gallery/ngx-gallery-helper.service.d.ts:1:22 - error TS2724: Module '"node_modules/@angular/core/core"' has no exported member 'Renderer'. Did you mean 'Renderer2'?
Can you please fix this?

@kolkov
Copy link

kolkov commented Apr 8, 2020

Hi! Try to use this version for Angular 8, 9.
https://www.npmjs.com/package/@kolkov/ngx-gallery

@ashismo
Copy link
Author

ashismo commented Apr 9, 2020

Thanks for your reply. I have used this and the same has been broken. Please see the below image.
I have the below settings. Looks like the height is not working

this.galleryOptions = [
{
width: '100%',
height: '300px',
thumbnailsColumns: 4,
imageAnimation: NgxGalleryAnimation.Slide,
previewZoom: true,
previewZoomMax: 4,
previewZoomStep: 0.4,
imageSwipe: true,
previewRotate: true,
imageDescription: true,
fullscreenIcon: 'fas fa-compress',
previewFullscreen: true,
imageArrowsAutoHide: true,
preview: true,
actions: this.gallaryActions
},
// max-width 800
{
breakpoint: 800,
width: '100%',
height: '300px',
imagePercent: 80,
thumbnailsPercent: 20,
thumbnailsMargin: 20,
thumbnailMargin: 20,
previewZoom: true,
preview: true,
actions: this.gallaryActions
},
// max-width 400
{
breakpoint: 400,
width: '100%',
height: '300px',
fullWidth: true,
imageDescription: true,
preview: true,
actions: this.gallaryActions
}
];

image

@cehager
Copy link

cehager commented Apr 9, 2020 via email

@kolkov
Copy link

kolkov commented Apr 9, 2020

Thanks for your reply. I have used this and the same has been broken. Please see the below image.
I have the below settings. Looks like the height is not working

this.galleryOptions = [
{
width: '100%',
height: '300px',
thumbnailsColumns: 4,
imageAnimation: NgxGalleryAnimation.Slide,
previewZoom: true,
previewZoomMax: 4,
previewZoomStep: 0.4,
imageSwipe: true,
previewRotate: true,
imageDescription: true,
fullscreenIcon: 'fas fa-compress',
previewFullscreen: true,
imageArrowsAutoHide: true,
preview: true,
actions: this.gallaryActions
},
// max-width 800
{
breakpoint: 800,
width: '100%',
height: '300px',
imagePercent: 80,
thumbnailsPercent: 20,
thumbnailsMargin: 20,
thumbnailMargin: 20,
previewZoom: true,
preview: true,
actions: this.gallaryActions
},
// max-width 400
{
breakpoint: 400,
width: '100%',
height: '300px',
fullWidth: true,
imageDescription: true,
preview: true,
actions: this.gallaryActions
}
];

image
Do you have this class?
kolkov/ngx-gallery#8

@cehager
Copy link

cehager commented Apr 9, 2020 via email

@saifansari2
Copy link

https://github.com/kolkov/ngx-gallery

this is not working with dynamic binding with api post response

static binding is working fine

@saifansari2
Copy link

it is not working with .webp format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants