Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up html5sortable.ts into smaller modules #555

Open
6 tasks
lukasoppermann opened this issue Aug 18, 2020 · 1 comment
Open
6 tasks

Split up html5sortable.ts into smaller modules #555

lukasoppermann opened this issue Aug 18, 2020 · 1 comment

Comments

@lukasoppermann
Copy link
Owner

lukasoppermann commented Aug 18, 2020

It would be good to split the html5sortable.ts file into smaller modules to make it easier to test them and understand the code.

Important would be:

  • try to avoid using globals as much as possible (always inject arguments in functions rather tan relying on options)
  • try to include typescript definitions for the functions
  • try to include tests for the new parts
  • try to see if we can generalize a function so that it can be reused for other parts
  • include comments and documentations in the module files
  • try to make the function naming convention more straight forward, logical and homogeneous

Good candidates are:

@lukasoppermann
Copy link
Owner Author

Hey @kaffarell if you have time to ship in here that would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant