Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled items are erroneously allowed to be dragged #477

Open
kartik-v opened this issue Dec 5, 2018 · 1 comment
Open

Disabled items are erroneously allowed to be dragged #477

kartik-v opened this issue Dec 5, 2018 · 1 comment

Comments

@kartik-v
Copy link

kartik-v commented Dec 5, 2018

I'm opening this issue because:

  • disabled items should never be draggable and sortable

supporting information:

  • I use sortable version: latest version
  • I tested in the following browser (incl. versions): Chrome
  • Windows, OS X/macOS, or Linux?: Windows

How can the issue be reproduce the problem?

Steps to reproduce:

  • Navigate to the examples page
  • Go to the third example of Exclude Items
  • The positive test works - Try dragging the normal enabled list items a few times
  • The negative test fails - Try dragging the disabled item - you can drag it by hard holding the mouse on the item and slightly dragging it left or right - then you can place it anywhere before or after other items
  • When you try to drag the disabled item - it allows you to thus drag and move / reorder the item - which as per definition should not be draggable

Thank you for contributing!

Before creating a feature requests, please review the existing feature requests and make sure there isn't one that already describes the feature you are missing:
https://github.com/lukasoppermann/html5sortable/issues?q=is%3Aopen+is%3Aissue+label%3Afeature

What's the feature?

What problem is the feature intended to solve?

Is this feature similar to an existing feature in another project?

@lukasoppermann
Copy link
Owner

Hey, thanks for the report. It is very hard to reproduce in chrome, but once I got it too.

It would be really awesome if you could send a PR with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants