Feature Request: Only show indent lines on my current code "block"

[twiclo]

Say I have this code block

impl Location {
│ pub async fn get_by_id(id: i32) -> Result<Self, Error> {
│ │ Ok(sqlx::query_as!(Self, r#"SELECT * FROM location WHERE location_id = $1"#, id).fetch_one(&ctx.pool).await?)
│ }
}

impl Address {
│ pub async fn get_by_id(id: i32) -> Result<Self, Error> {
│ │ Ok(sqlx::query_as!(Self, r#"SELECT * FROM location WHERE location_id = $1"#, id).fetch_one(&ctx.pool).await?)
│ }█
}

Notice the cursor is in the second code block. I would hope the guides would only show under the impl Address block:

impl Location {
  pub async fn get_by_id(id: i32) -> Result<Self, Error> {
    Ok(sqlx::query_as!(Self, r#"SELECT * FROM location WHERE location_id = $1"#, id).fetch_one(&ctx.pool).await?)
  }
}

impl Address {
│ pub async fn get_by_id(id: i32) -> Result<Self, Error> {
│ │ Ok(sqlx::query_as!(Self, r#"SELECT * FROM location WHERE location_id = $1"#, id).fetch_one(&ctx.pool).await?)
│ }█
}

I think it could look cleaner

[lukas-reineke]

I'm not against the idea, but this would actually be pretty difficult to add with the current implementation.

[windowsrefund]

Practically speaking, it seems like you are looking for twilight

[ndom91]

Wasn't this possible in < v3 with the show_current_context = true option? I remember thats how mine used to work and I'm trying to get it to behave the same with v3 without any luck :/

[lukas-reineke]

No, this was never supported and still isn't.

[Danielkonge]

I have a small addition to the code that does this now, but what behavior would you want when the cursor is between the two impl blocks? Should it show indents for both or no indents at all? (My current code shows no indentations when you are not inside any block, since this can then also be used to save some work.)

[twiclo]

I think showing indents for everything is a fine idea. I would say make it a setting so users can choose. Thanks for doing the work on this

[Danielkonge]

Ah, I just edited it to not show indents when not in a block now, since I thought that could save work too. But this could definitely be an option, though I worry adding extra options to what is already a sub-option could be confusing. I would probably want @lukas-reineke's input on how we would want this to be implemented before adding that kind of option.

If you want me to change anything (I have only briefly checked that it worked as I expected), you can try it from my latest commit here: #703

The option can be enabled by adding something like indent = { current_block_only = true } to your config when using that commit.

[lukas-reineke]

Your PR is already really big, let's focus on current indent first. I'm happy to add this as well, but let's make that a separate PR.
Then we can discuss there how it should work.

[Danielkonge]

If you didn't see, I also asked in the PR if you prefer to have it split up. I will just split it into smaller parts tomorrow.