New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The official tests #5
Comments
Awesome, thanks! |
@lujakob is this already implemented or is it still pending a PR from @sebilasse ? Please update. |
@sajidali There is no PR to update this. |
@sebilasse please submit PR with your bug fixes... |
@sebilasse please submit PR with your bug fixes... 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there,
thanks for the work.
I've just run this project vs the official RealWorld API Tests : I would suggest to use these for testing.
[ Currently they return one false negative ( I had corrected that in the testcode already) but there are 2 PRs for that, e.g. https://github.com/gothinkster/realworld/issues/309 ]
There are a few problems like with the relations.
It looks like this
I have corrected the bugs and it looks like this
I'd prefer to make a fork and change it there so that you can review the code before merging anything.
The text was updated successfully, but these errors were encountered: