Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to stub cookies for normal (non-directed requests) #110

Open
mjholgate opened this issue Apr 24, 2015 · 1 comment
Open

Not able to stub cookies for normal (non-directed requests) #110

mjholgate opened this issue Apr 24, 2015 · 1 comment

Comments

@mjholgate
Copy link
Contributor

Please see the new unit test I've added here:

https://github.com/mjholgate/Nocilla/tree/set-cookie-unit-test

It fails, but I think it should pass (i.e. the cookie should be set, and should be able to be read back from the cookie store).

Weirdly, the existing unit test which does the same thing for redirected requests (http status code 301), works fine.

@mjholgate
Copy link
Contributor Author

Added a fix for the bug to the pull request.

patcheng added a commit to patcheng/Nocilla that referenced this issue Sep 30, 2015
* master: (32 commits)
  Allow identical stubs to be replaced so that their response can be altered.
  Added short warning on async request testing, added company MessageBird url
  Bump version to 0.10.0
  Added LSDataMatcherSpec
  Better implementation - less intrusive
  Converting NSData to NSString can be nil if arbitrary data. So best to keep NSData for comparison
  Fix for luisobo#110: Process Set-Cookies for all requests.
  A unit test for testing that cookies are set on regular requests.
  Fix public header paths in podspec
  Update podspec
  Fix bundle identifier
  Remove NocillaTests.m
  Run pod install on travis
  Update cocoapods
  Use xcpretty
  Update Kiwi to 2.3.1
  Use xcodebuild instead of xctool
  Run tests in Debug configuration
  Retrigger CI
  Lower deployment target
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant