Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest etsi specification conformance #144

Open
michelebortolato opened this issue Jan 9, 2018 · 4 comments
Open

Latest etsi specification conformance #144

michelebortolato opened this issue Jan 9, 2018 · 4 comments
Labels

Comments

@michelebortolato
Copy link

Hi

I would like to know if there are some problemi to extend this library in order to be compliant to the lates etsi specification:

ETSI EN 319 132-1 V1.1.0 (2016-02)

For example some element are deprecated in this version (SignerRoleV2 instead of SignerRole)

Signature made in the old format should be rejected

thanks

@luisgoncalves
Copy link
Owner

Hello. To be honest, I haven't checked the new specs (the document you mention and the companion -2). For properties such as SignerRole it may be fairly easy to extend. A bit harder could be to make both specs coexist, namely in signature validation..

@michelebortolato
Copy link
Author

Ok, let's suppose i don't care about verification at a first moment, i have only to update the xsl into schema folder and then recreate the jaxb java file (and adapt some method)?

@luisgoncalves
Copy link
Owner

If you regenerate the JAXB classes, then I think you'd need to update the converter classes (From/To Xml) in the (un)marshalling namespace to use the new properties. If the data in the high level property classes (e.g. SignerRoleProperty) is sufficient to feed the new version, you should be fine. Otherwise, you'll need to change the classes on the layers above.

@michelebortolato
Copy link
Author

Hi Luis

I made my modifies. I works but i am not sure if allt the other functionalities remains valid (the validation p.es, i don't look spo much at it because i don't need it). For this reason i don't know if you want to include them in your effective project.
I updated all my modifies in a fork (https://github.com/michelebortolato/xades4j), give it a look if you want.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants