Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue running specs on fresh app #93

Open
jwoertink opened this issue Sep 1, 2020 · 2 comments
Open

Issue running specs on fresh app #93

jwoertink opened this issue Sep 1, 2020 · 2 comments
Labels
clarify api Rename/remove/add something to make the API easier to understand help wanted Additional expertise needed improve error experience Make errors nicer to deal with

Comments

@jwoertink
Copy link
Member

I installed a fresh Lucky 0.23 app and tried to run specs only to get this error:

session not created: session not created: This version of ChromeDriver only supports Chrome version 83

(assuming I was a brand new dev to Lucky...) I first think "What version of chromedriver do I have installed?". It was version 80. I ran brew upgrade chromedriver, checked the version chromedriver -v and I got 85. Ran crystal spec, and it failed with the same error. I then checked my version of chrome, it updated and showed version 85. Still unable to run the specs....

I dug in to LuckyFlow to find this line where LuckyFlow.settings.chromedriver_path was nil. I didn't know I had to set this path (because I'm new). But I saw that Webdrivers::Chromedriver.install pointed to ~/.webdrivers/chromedriver. It happened that this version was 83. I had to uninstall this version since it wasn't managed by my package manager, and also uninstall my local chromedriver. Then when I ran crystal spec, I see it installed the correct version and specs passed.

Maybe there's a way we can catch that error, and present a nicer error to say delete this cache directory, or something?

/cc. @matthewmcgarvey

@jwoertink jwoertink added clarify api Rename/remove/add something to make the API easier to understand help wanted Additional expertise needed improve error experience Make errors nicer to deal with labels Sep 1, 2020
@matthewmcgarvey
Copy link
Member

The webdrivers library has functionality to know when to update the chromedriver it has installed. I wonder why that didn't happen 🤔

@jwoertink
Copy link
Member Author

I'm not sure. It had said that the version installed was from June. Maybe I had a weird edge case where I installed that before you added that part in? But then I guess having the latest flow should still have read that and seen it needed to be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarify api Rename/remove/add something to make the API easier to understand help wanted Additional expertise needed improve error experience Make errors nicer to deal with
Projects
None yet
Development

No branches or pull requests

2 participants