Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code not archived by archiver.bbclass #28

Open
rhaberkorn opened this issue Jan 25, 2024 · 4 comments
Open

Source code not archived by archiver.bbclass #28

rhaberkorn opened this issue Jan 25, 2024 · 4 comments

Comments

@rhaberkorn
Copy link

In order to comply with the GPL-licensing of the OpenJDK, you must provide source code with commercial products containing the OpenJDK. Yocto foresees the archiver.bbclass for that purpose.

Unfortunately, since the current Temurin recipes reference binary archives, any source archive created by the archiver class will not contain the necessary sources.

I would therefore suggest to add sources with the unpack=false attributes to all recipes. For instance

SRC_URI += "https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10%2B7/OpenJDK17U-jdk-sources_17.0.10_7.tar.gz;md5sum=8556055f844508d2c9cfc930cc9a1570;unpack=false"

This worked as a test in my case. The archiver will bundle both the binary and source archives in this case. The binaries are unnecessary for source archives, but I don't know how to exclude them elegantly, except doing it in a script.

@sebveit
Copy link
Contributor

sebveit commented Jan 26, 2024

Thanks for the feedback! I'll look into it.

@sebveit
Copy link
Contributor

sebveit commented May 29, 2024

Sorry for the delay. I have adapted the recipes to supply the source code of the JREs accordingly.
See commit b7dd04b

Please verify if that works as intended!

@rhaberkorn
Copy link
Author

Thank you. Could you port this to the dunfell branch as well, please? (Actually I am using it with hardknott, but it works as well.)

@rhaberkorn
Copy link
Author

rhaberkorn commented Jun 3, 2024

The kirkstone branch, that already contains your patch, should also build with hardknott, but I get the following error at install time: log.do_install.35245.gz

The directory should be called ...jvm/openjdk-17-jre/jdk-17.0.10+7-jre/bin - there is an unexpected jdk-17.0.10+7-jre subdirectory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants