Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support sections taller than the viewport #16

Open
hatsumatsu opened this issue Dec 14, 2019 · 4 comments
Open

[Enhancement] Support sections taller than the viewport #16

hatsumatsu opened this issue Dec 14, 2019 · 4 comments

Comments

@hatsumatsu
Copy link

Cool little library! A great addition would be the option to have sections taller than the viewport. They could snap to the top and have free scrolling until you reach their end.

This is currently not possible with CSS snap points and would be a handy advantage compared to the native implementation...

@lucafalasco
Copy link
Owner

Thanks @hatsumatsu.
You can actually already implement this pretty easily with a nested scroll using basic CSS:

Edit scroll-snap-react-nested-scroll

@hatsumatsu
Copy link
Author

@lucafalasco This comes close but also creates double scrollbars which gives it a hacky feel.
Screenshot 2020-02-05 at 16 57 45

@lucafalasco
Copy link
Owner

lucafalasco commented Feb 5, 2020

@hatsumatsu yes, I agree the behaviour may be improved.
I might consider working on a better solution in the future.. otherwise a PR is more then welcome if you’d like to work on this! 😉

@hatsumatsu
Copy link
Author

@lucafalasco thanks for getting back. I'll take a look at the code and see if I can make this work ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants