Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map_gen() is defined twice #51

Open
Wiladams opened this issue Aug 1, 2019 · 0 comments
Open

map_gen() is defined twice #51

Wiladams opened this issue Aug 1, 2019 · 0 comments
Assignees
@Totktonada
Labels
code health

Comments

@Wiladams
Copy link

Wiladams commented Aug 1, 2019

the name map_gen is used twice as local functions. In both cases it's used immediately by some function that is close by. It seems a bit dangerous though in case the code is ever shifted around.

One or the other should probably change name. Maybe one could be gen_map?
@kyukhin kyukhin added the bug label Sep 24, 2021
@kyukhin kyukhin added this to the wishlist milestone Sep 24, 2021
@kyukhin kyukhin modified the milestone: wishlist Oct 15, 2021
@igormunkin igormunkin added code health and removed bug labels Mar 1, 2023
@igormunkin igormunkin removed this from the wishlist milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Totktonada Totktonada

Labels
code health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Totktonada @Wiladams @igormunkin @kyukhin