remove_if name misleading

[yurikhan]

Documentation says:

fun.remove_if(predicate, gen, param, state)
iterator:remove_if(predicate)

An alias for filter().

The name remove_if strongly suggests that elements satisfying the predicate will be removed, keeping only those that do not satisfy the predicate; while filter actually keeps the elements satisfying the predicate.

In other words, the linguistic expectation would be that remove_if is sugar for filter(function(x) return not p(x) end).

(Of course it’s your call how to solve this without breaking existing code if any. I’d suggest deprecating the remove_if name for a while.)