Skip to content
This repository has been archived by the owner on Mar 26, 2023. It is now read-only.

Inactive session #247

Open
Martin2877 opened this issue May 19, 2021 · 5 comments
Open

Inactive session #247

Martin2877 opened this issue May 19, 2021 · 5 comments

Comments

@Martin2877
Copy link

Hi! It's an awesome project and I really like it.

image

Can you add a survivability test, delete the inactive session, or turn it red, otherwise I don’t know which ones have expired sessions.

@JustinTimperio
Copy link
Contributor

I have a patch for this, I just have yet to commit it. I will try and submit this by the end of week

@lu4p
Copy link
Owner

lu4p commented May 19, 2021

@JustinTimperio nice

@lu4p
Copy link
Owner

lu4p commented Jul 20, 2021

@JustinTimperio friendly ping in case you forgot

@JustinTimperio
Copy link
Contributor

Thanks for the ping @lu4p. There is an issue where dead connections duplicate which I have fixed, but looking at this closely, I think a timed-interval connection check would also be good. The issue is that it is nice to know that connection is dead, and if it is just silently removed from the list that's not super helpful. Perhaps a notification when it dies?

@lu4p
Copy link
Owner

lu4p commented Jul 22, 2021

Yeah just a simple notification should work.

[-] Client %name disconnected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants