Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle fonts with web assets #27

Open
zainab-ali opened this issue Nov 12, 2020 · 1 comment
Open

Bundle fonts with web assets #27

zainab-ali opened this issue Nov 12, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@zainab-ali
Copy link
Collaborator

The site displays text using the free fonts Adobe Source Serif Pro and Adobe Source Sans Pro.
These are not distributed with the site. If a user doesn't have them installed on their PC, we use their defaults instead. This causes styling issues.
We should bundle the fonts with the site assets such that all users see the correct fonts.

Potential Solution

The mill build must be adjusted to include bundling fonts. A task should be added under the web module to download and unzip the fonts from their GitHub releases:

Tests

Manual testing is satisfactory.

Prerequisites

  • The basics of CSS and font families
  • Enough familiarity with Scala to work with mill

What you'll learn

This is a great introduction to mill, outside of standard Scala projects

Getting started

Read our Contributor Guide to get set up.

@zainab-ali zainab-ali added the good first issue Good for newcomers label Nov 12, 2020
@mazhara
Copy link
Contributor

mazhara commented Dec 12, 2020

I would like to take this one

mazhara pushed a commit to mazhara/lsug-website that referenced this issue Jan 17, 2021
mazhara pushed a commit to mazhara/lsug-website that referenced this issue Feb 28, 2021
mazhara pushed a commit to mazhara/lsug-website that referenced this issue Feb 28, 2021
mazhara pushed a commit to mazhara/lsug-website that referenced this issue Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants