You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The site displays text using the free fonts Adobe Source Serif Pro and Adobe Source Sans Pro.
These are not distributed with the site. If a user doesn't have them installed on their PC, we use their defaults instead. This causes styling issues.
We should bundle the fonts with the site assets such that all users see the correct fonts.
Potential Solution
The mill build must be adjusted to include bundling fonts. A task should be added under the web module to download and unzip the fonts from their GitHub releases:
The site displays text using the free fonts Adobe Source Serif Pro and Adobe Source Sans Pro.
These are not distributed with the site. If a user doesn't have them installed on their PC, we use their defaults instead. This causes styling issues.
We should bundle the fonts with the site assets such that all users see the correct fonts.
Potential Solution
The mill build must be adjusted to include bundling fonts. A task should be added under the web module to download and unzip the fonts from their GitHub releases:
- https://github.com/adobe-fonts/source-sans-pro/releases/tag/3.028R/source-sans-pro-3.028R.zip
We should make sure the version string can be incremented easily (though not automatically).
The fonts themselves are specified in the
fonts.scss
file. This should be amended to use@fontface
to fetch the font.Tests
Manual testing is satisfactory.
Prerequisites
What you'll learn
This is a great introduction to mill, outside of standard Scala projects
Getting started
Read our Contributor Guide to get set up.
The text was updated successfully, but these errors were encountered: