Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Python usage? #9

Open
sblisesivdin opened this issue Sep 17, 2021 · 2 comments
Open

Better Python usage? #9

sblisesivdin opened this issue Sep 17, 2021 · 2 comments
Assignees
@sblisesivdin
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@sblisesivdin
Copy link
Contributor

Up to this point, code simplicity, and better readability were important. However, to reach a wider developer spectrum, it may be better to use better Python practices. Usage of function based structure, usage of main etc.
@sblisesivdin sblisesivdin added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Sep 17, 2021
@sblisesivdin sblisesivdin self-assigned this Sep 17, 2021
@sblisesivdin
Copy link
Contributor Author

Unused global variables can be seen along the code. It is just because the gpawsolve.py and asapsolve.py are just very long script files. It is still logical to think change the structure of these files from scripts to modules.

@sblisesivdin
Copy link
Contributor Author

With 810da0d gpawsolve.py is not a direct script file anymore. It has a gpawsolve class and for each calculation type, there are functions in it. The usage of variables is not good yet and can not be appropriately used as a module for now, however, it works. Further changes will be made for proper module usage.

@sblisesivdin sblisesivdin added good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sblisesivdin sblisesivdin

Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sblisesivdin