Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Battery bar indicator color enhancement #145

Open
RaffaeleBianc0 opened this issue Aug 15, 2022 · 4 comments · May be fixed by #157
Open

Battery bar indicator color enhancement #145

RaffaeleBianc0 opened this issue Aug 15, 2022 · 4 comments · May be fixed by #157

Comments

@RaffaeleBianc0
Copy link

Hi there!
Outstanding script, thank you for the great job!

I'd like to file this tiny enhancement request:
the battery bar indicator could be reversed, like "red" on the left and "green" on the right, for obvious reasons.
@rashil2000
Copy link
Member

It would require adding a param to the get_percent_bar and get_level_info functions. Would you like to make a PR?

@RaffaeleBianc0
Copy link
Author

Sorry I can't

@RaffaeleBianc0
Copy link
Author

Sorry for the short reply above - let me explain better: I am a total noob both with PowerShell scripting AND with GitHub architecture.
I don't know if opening an "Issue" is the right way to propose an enhancement request, but that's the only thing I wanted to do.
I just googled on this topic, and it seems to me that GitHub doesn't have a dedicated area where to file "feature requests", and they all go in the same basket of the "Issues".
Sorry if I bothered you with all this. :-)

@rashil2000
Copy link
Member

This is the right place for feature requests, so don't worry about it.

I or some other contributor can consider adding it, when we have time.

@FantasyTeddy FantasyTeddy linked a pull request Sep 29, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve battery bar colors FantasyTeddy/winfetch
2 participants
@RaffaeleBianc0 @rashil2000