Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This script requires a special version of weighttp which supports JSON output #270

Open
nalzok opened this issue Sep 10, 2019 · 1 comment

Comments

@nalzok
Copy link
Contributor

nalzok commented Sep 10, 2019

I can't run make benchmark even after this fork of weighttp is installed.

pi@nalzoks-pi:~/Downloads/lwan/build $ make benchmark
[  3%] Built target bin2hex
[  5%] Built target generate_auto_index_icons
[ 15%] Built target mimegen
[ 16%] Built target generate_mime_types_table
[ 94%] Built target lwan-static
[ 98%] Built target testrunner
[100%] Running benchmark.
Using /home/pi/Downloads/lwan/build/src/bin/testrunner/testrunner for lawn
This script requires a special version of weighttp which supports JSON
output. Get it at http://github.com/lpereira/weighttp
make[3]: *** [CMakeFiles/benchmark.dir/build.make:58: CMakeFiles/benchmark] Error 1
make[2]: *** [CMakeFiles/Makefile2:73: CMakeFiles/benchmark.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:80: CMakeFiles/benchmark.dir/rule] Error 2
make: *** [Makefile:164: benchmark] Error 2

A quick skim of its source code doesn't reveal any JSON related code; in fact, it doesn't even take a -j argument.

https://github.com/lpereira/weighttp/blob/ffd0439e447ef20169d08b5581a4f0770cf43f73/src/weighttp.c#L136-L172

@lpereira
Copy link
Owner

I apologize for not seeing this issue before. That script is unfortunately out-of-date; it should be adapted to use this rewrite, which has a JSON output and fixes a bunch of issues with the official code. The output is slightly different but it should be possible to modify the script to accommodate for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants