Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dv] Improve instruction trace around faulting instructions #2099

Open
GregAC opened this issue Nov 8, 2023 · 0 comments
Open

[dv] Improve instruction trace around faulting instructions #2099

GregAC opened this issue Nov 8, 2023 · 0 comments
Labels
Component:DV Design verification (DV) or testing issue Type:Enhancement Feature requests, enhancements

Comments

@GregAC
Copy link
Collaborator

GregAC commented Nov 8, 2023

When an executed instruction generates a fault we suppress its destination register write. On the RVFI interface this mean setting the write register index to 0. On the instruction trace this results in seeing x0 as the destination register, rather than the actual destination register. This can be confusing. We should improve our trace output to include the actual destination register in the printed instruction along with a note the write is suppressed due to a trap.

See lowRISC/opentitan#13134 for an example of this issue.

@GregAC GregAC added Type:Enhancement Feature requests, enhancements Component:DV Design verification (DV) or testing issue labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV Design verification (DV) or testing issue Type:Enhancement Feature requests, enhancements
Projects
None yet
Development

No branches or pull requests

1 participant