New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample domain in Faraday docs needs to be updated #1164
Comments
Thanks @mokolabs for raising this. I'd also be glad if someone from the community would like to pick this up, I'll flag it as a good first issue 👍 |
Okay, cool. I can take this one on. |
I use |
Hi all, would like to start contributing trying to help with the doc for while, i attach a pull request suggesting an adjustment. |
@JAugusto42 Cool, thanks for fixing that - does that complete this ticket? |
I believe so, i'm going to go through the other pages...but i believe that's it. |
There are still occurrences of |
sure i can work on that |
now I don't think it has any more references to sushi.com |
Belatedly... thank you for fixing this, @JAugusto42! |
Basic Info
Issue description
Faraday docs use
sushi.com
as a sample domain for code examples. However, it appears registration for the domain lapsed at some point, and it was grabbed by a domain name scalper.As a result, many of the existing code examples either don't work at all or produce divergent output from the docs.
For instance, the very first code example:
In fact, this returns a
301
because the new host for thesushi.com
domain is redirecting http requests to https. If you follow the redirect via Faraday (with the extra required code), you'll eventually get a404
becausesake.json
no longer exists on the domain.Steps to reproduce
See above.
The text was updated successfully, but these errors were encountered: