New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait until CodeClimate supports SimpleCov 0.18+, then re-add badge & code coverage collection #1139
Comments
Thinking harder about this, I kind of want not to have CodeClimate's Go program hold SimpleCov back. I will opt to remove their coverage badge from the README instead. We can put the badge back when they support SimpleCov 0.18+. Reporter issue here: https://github.com/colszowka/simplecov/releases have a lot of action going on. |
With any such removal would come "drop the CI stuff that transmits the coverage data as well". |
Indeed we should not downgrade SimpleCov just because it's not supported by CodeClimate's test-reporter. Agree with disabling the test-reporter until a fix is pushed |
Great news! |
We've removed codeclimate, closing this |
Basic Info
Issue description
Our reporting of code coverage to Codeclimate always fails. That's due to them not supporting the 0.18+ format of SimpleCov output (branch coverage etc).
I recognized the error output in the codeclimate reporter's 2nd step: a Go failure to parse the newer SimpleCov format.
Proposal: Downgrade simplecov to a codeclimate-supported version, and keep a code comment there to remind us of that.Proposal, update: Disable coverage reporting and badge until Codeclimate supports all of SimpleCov. This Issue can be kept open as a tracking issue for this.
Steps to reproduce
See this GH Actions failure: https://github.com/lostisland/faraday/runs/543272466?check_suite_focus=true#step:9:8
When CI runs past that step, only in Ruby 2.6 that program is run. Exit code is 255 on failure, and the output looks like the above.
The text was updated successfully, but these errors were encountered: