Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please backport and release ruby 2.7 fixes #1080

Closed
zenspider opened this issue Nov 22, 2019 · 8 comments
Closed

Please backport and release ruby 2.7 fixes #1080

zenspider opened this issue Nov 22, 2019 · 8 comments

Comments

@zenspider
Copy link

@tenderlove's PR #1009 was merged but only to master. Can we get it backported to the 0.1x branch and released? Ruby 2.7 is mere weeks away and this is biting our CI.

@technoweenie
Copy link
Member

Thanks for the heads-up, I'll take care of it today.

@technoweenie
Copy link
Member

Alrighty, should be good to go. I'll leave this open until someone can confirm the warnings are gone.

🦃

@connorshea
Copy link

I was just testing 2.7 and got a lot of this warning:

/Users/connorshea/.rbenv/versions/2.7.0-preview3/lib/ruby/gems/2.7.0/gems/faraday-0.17.1/lib/faraday/options.rb:166: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead

But it looks like that was fixed by c56732c

That's the only deprecation warning from Faraday that I can see. Any chance you could do another release with it? 🙇

@kapso
Copy link

kapso commented Dec 26, 2019

Curious whats the release date for this fix? Thanks.

@iMacTia
Copy link
Member

iMacTia commented Dec 27, 2019

I'm on it guys 👍
That branch was merged being tested only against Ruby 2.3+ because of an issue with GitHub Actions.
I'm trying to get it to run against all supported Rubies (1.9+) before releasing, as we can't be sure it will work on older versions

@iMacTia
Copy link
Member

iMacTia commented Dec 27, 2019

Unfortunately, I was right to worry 😞: https://github.com/lostisland/faraday/pull/1087/checks?check_run_id=365035952#step:6:74

@iMacTia
Copy link
Member

iMacTia commented Dec 27, 2019

I managed to get the CI running for Ruby 2.0+ 🎉
I'm going to merge that in and release 0.17.2

This was referenced Dec 27, 2019
@iMacTia
Copy link
Member

iMacTia commented Jan 8, 2020

@technoweenie released 0.17.2 and 0.17.3 so this is now officially available ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants