#get is not thread safe

[ioquatix]

faraday/lib/faraday/adapter_registry.rb

Lines 14 to 26 in d5eaa4f

	def get(name)
	klass = @constants[name]
	return klass if klass
	Object.const_get(name).tap { |c| set(c, name) }
	end
	def set(klass, name = nil)
	name ||= klass.to_s
	@lock.synchronize do
	@constants[name] = klass
	end
	end

Reading from a hash table while there are updates happening is not thread safe.

[iMacTia]

Ah I see what you mean, should we move the @lock.synchronise call into get instead?
I'm not sure we'd need it in set anymore after that?

[ioquatix]

You need it in both methods because you are reading and writing to @constants. You can't have synchronised access to the same hash table in any sitautions. Read only operations are not safe with simultaneous writes.

[olleolleolle]

Alright, I merged a change to wrap the @constants in a synchronize.

[olleolleolle]

Thanks, @ioquatix for the inspiration!