fix linkedin regexes #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2020 12:33
lorey
reviewed
May 7, 2020
| RegEx for public URLs. | ||
|
|
||
| http(s)?:\/\/([\w]+\.)?linkedin\.com\/pub\/[A-z0-9_-]+(\/[A-z0-9]+){3}\/? | ||
| http(s)?:\/\/([\w]+\.)?linkedin\.com\/pub\/[\w\-À-ÿ%]+(\/\w+){3}(\/.*)? |
There was a problem hiding this comment.
Hey @Ronserruya, thanks for the PR. Could you help me understand the À-ÿ part?
There was a problem hiding this comment.
Sure, \w gets all English letters, but you need À-ÿ to catch accented letters, that's for people with these letters in their name, for example
|
Hey @Ronserruya, sorry I changed the structure but it seemed right to structure the data and add tests. Could you please add your regexes to the regexes.json file or just post some (anoymized) sample URLs here, so I can add and verify them myself? Tried to find examples with google but couldn't find any, sorry! |
|
Closing this for now, feel free to create a new issue or PR! 💯 |
|
No problem, I'll get to it in the next few days :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
Tested this on a list of a few thousands of user links, hope this helps :)