Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make indicator boundary customisable #106

Open
assignUser opened this issue Jan 18, 2022 · 1 comment
Open

Make indicator boundary customisable #106

assignUser opened this issue Jan 18, 2022 · 1 comment

Comments

@assignUser
Copy link
Collaborator

I just looked at kgoldfeld/simstudy#129 And I wondered if the users could be a able to specify a threshold himself for the icon. Does it always make sense to check if 0 is contained? One could argue that a ci that contains a 1% performance drop is still not enough to justify a 🐌 icon, so if the user specifies a custom value for null_boundary (Better name needed I think ), we check if the confidence interval overlaps with it.

Originally posted by @lorenzwalthert in #71 (comment)

@assignUser
Copy link
Collaborator Author

I agree, that would be good, maybe something like max_performance_loss or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant