Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batteryVoltage and batteryChargeCurrent are sent with every beacon #28

Open
hb9fef opened this issue Jun 6, 2021 · 1 comment
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hb9fef
Copy link

hb9fef commented Jun 6, 2021

if (BatteryIsConnected) { aprsmsg += " - _Bat.: " + batteryVoltage + "V - Cur.: " + batteryChargeCurrent + "mA"; } (line 239 of LoRa_APRS_Tracker.cpp) should be inside of if (!(rate_limit_message_text++ % 10)) just above that section.

In the current version the battery status is sent with every single beacon (9 times) while 'aprsmsg + Config.beacon.message + Battery status' will be sent only every 10th time.

As a consequence, the user configured message is not visible on aprs.fi 9 out of 10 times.

@stroobandt
Copy link

stroobandt commented Apr 16, 2022

Again, that is an insane waste of LoRa Bytes, unnecessary limiting channel capacity and chances on successful packet reception!

Luckily, I do not see this with my T-Beam v0.7, which thinks it remains connected to USB power all the time, even when it is solely cell operated. T-beam v1.0 users have less luck.

@peterus peterus added enhancement New feature or request help wanted Extra attention is needed labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants