Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT][v1.6.3][IMPROVEMENT] Resolve all golangci-lint warning #8556

Open
github-actions bot opened this issue May 13, 2024 · 1 comment
Open

[BACKPORT][v1.6.3][IMPROVEMENT] Resolve all golangci-lint warning #8556

github-actions bot opened this issue May 13, 2024 · 1 comment
Assignees
@FrankYang0529
Labels
area/build-package Build & Package related area/ci CI related (PR, release, etc) kind/backport Backport request kind/improvement Request for improvement of existing function
Milestone
v1.6.3

Comments

@github-actions
Copy link

backport #7448
@github-actions github-actions bot added area/build-package Build & Package related area/ci CI related (PR, release, etc) kind/backport Backport request kind/improvement Request for improvement of existing function labels May 13, 2024
@github-actions github-actions bot added this to the v1.6.3 milestone May 13, 2024
This was referenced May 13, 2024
Open
Open
Open
Open
Open
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented May 13, 2024 •
edited by FrankYang0529

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?

  • Is there a workaround for the issue? If so, where is it documented?

  • Does the PR include the explanation for the fix or the feature? Yes

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    fix: golangci-lint error (backport #2740) longhorn-manager#2801
    fix: golangci-lint error (backport #1084) longhorn-engine#1111
    fix: golangci-lint error (backport #478) longhorn-instance-manager#499
    fix: golangci-lint error (backport #229) backing-image-manager#245
    fix: golangci-lint error (backport #191) longhorn-share-manager#219

  • Which areas/issues this PR might have potential impacts on?
    Area
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankYang0529 FrankYang0529

Labels
area/build-package Build & Package related area/ci CI related (PR, release, etc) kind/backport Backport request kind/improvement Request for improvement of existing function
Projects
None yet
Milestone
v1.6.3
Development

No branches or pull requests
2 participants
@FrankYang0529 @longhorn-io-github-bot