Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Expose local logical volume and attach it to local node #8551

Closed
derekbit opened this issue May 13, 2024 · 3 comments
Closed
Assignees
Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone

Comments

@derekbit
Copy link
Member

derekbit commented May 13, 2024

Is your improvement request related to a feature? Please describe (馃憤 if you like this request)

Expose local logical volume and attach it to local node

  1. Expose local logical volume and attach it to local nodes
  2. To expose a logical volume and attach it to the local node, NGUID should be provided.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

cc @DamiaSan @shuo-wu

@derekbit derekbit added priority/0 Must be fixed in this release (managed by PO) require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated kind/improvement Request for improvement of existing function area/v2-data-engine v2 data engine (SPDK) require/backport Require backport. Only used when the specific versions to backport have not been definied. labels May 13, 2024
@derekbit derekbit added this to the v1.7.0 milestone May 13, 2024
@derekbit derekbit self-assigned this May 13, 2024
@DamiaSan
Copy link
Contributor

DamiaSan commented May 13, 2024

This feature is needed by:

@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented May 13, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

Verify

  1. v2 volume attachment and detachment
  2. v2 volume backup and restore. Verify the data in a restored volume as well.
  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

  • Which areas/issues this PR might have potential impacts on?
    Area: v2 volume attachment/detachment
    Issues

@derekbit derekbit changed the title [IMPROVEMENT] Add NGUID in go-spdk-helper's NvmfSubsystemAddNs api [IMPROVEMENT] Expose local logical volume and attach it to local node May 13, 2024
@chriscchien chriscchien self-assigned this May 20, 2024
@chriscchien
Copy link
Contributor

Verified pass on longhorn master (longhorn-manager ebace7) with test steps

V2 volume attach, detach, create backup, restore from backup worked well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
None yet
Development

No branches or pull requests

4 participants