Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pause while rendering dialogue window #17

Open
Bluefissure opened this issue Oct 25, 2021 · 8 comments
Open

[Bug] Pause while rendering dialogue window #17

Bluefissure opened this issue Oct 25, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request Known Issue This is a known issue

Comments

@Bluefissure
Copy link
Contributor

When the dialogue windows pop up in cutscenes there'll be an obvious pause of rendering. I think it's caused by fetching the translated text from the API synchronously, which blocks the rendering procedure.

Is it possible to change it to async when replacing the text?

@Bluefissure Bluefissure changed the title [Improvement] Pause while rendering dialogue window [Enhancement] Pause while rendering dialogue window Oct 25, 2021
@Bluefissure Bluefissure changed the title [Enhancement] Pause while rendering dialogue window [Bug] Pause while rendering dialogue window Oct 25, 2021
@lokinmodar
Copy link
Owner

Doing some tests on my end. The routines are not yet ready for deployment in the next release yet. I'll release a new version without this for dialogues for now but i hopefully will have a solution for the micro-stutters on all scenarios in the subsequent release

@lokinmodar lokinmodar added enhancement New feature or request Known Issue This is a known issue labels Oct 25, 2021
@lokinmodar lokinmodar self-assigned this Oct 30, 2021
@VictorPozoSallent
Copy link

VictorPozoSallent commented Nov 7, 2021

I was gonna comment you the same of micro cuts, but ive seen someone already did it, keep up the work. You re doing an essential thing for alot of people, thanks alot.

Also, i unable system tranlation and it seems changes dotn aply becuase it still tranlates me some system things. One last quick question, when you release the version with no cuts, do i have to do something or it will auto update, thanks again.

@lokinmodar
Copy link
Owner

lokinmodar commented Nov 8, 2021 via email

@VictorPozoSallent
Copy link

VictorPozoSallent commented Nov 8, 2021

Thanks for the quick answer, and hopefully the micro cuts will be fixed soon, already uninstalled tataru, thanks for your job

Also quick question, did you though of implementig others translators like DeepL? :D

@SamaelDark
Copy link

SamaelDark commented Jan 26, 2022

Hi. The problem with microfreezes has been around for some time. The animation stops and the dialog box appears without translation. This happens 80% of the time. In fact, the plugin doesn't work.

@lokinmodar
Copy link
Owner

Hi. The problem with microfreezes has been around for some time. The animation stops and the dialog box appears without translation. This happens 80% of the time. In fact, the plugin doesn't work.

Yes indeed. I am having some problems due to work schedule and couldn't release a new version since the last one. Also, the translations not happening issue surfaced because Google is sending different responses when the plugin calls the api. I already have a fix for this specific issue but could not tie up the code for a new release yet. I may be able to do so by the next weekend. Sorry for all the trouble

@VictorPozoSallent
Copy link

This isnt sovled yet right? Im having same problem even if im suing 3.0 ver.

@lokinmodar
Copy link
Owner

lokinmodar commented Jul 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Known Issue This is a known issue
Projects
Status: In Progress
Development

No branches or pull requests

4 participants