Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is version 1.2.0 actually a breaking change? #45

Open
fprojetto opened this issue Feb 4, 2020 · 1 comment
Open

Is version 1.2.0 actually a breaking change? #45

fprojetto opened this issue Feb 4, 2020 · 1 comment

Comments

@fprojetto
Copy link

Version 1.2.0 changes the default behaviour of the plugin going from creating the subscription by default to not but allowing to opt-in for subscription creation using the create_subscription option. IMHO, that is a breaking change.

This is not a request to do anything but I would like to know what you think retrospectively. Are these kind of changes going to be considered as breaking changes so to bump the major version number?

Thanks!
@amrmotan
Copy link

amrmotan commented Feb 4, 2020

I agree.
I had to manually create the subscription when I upgraded my logstash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fprojetto @amrmotan