Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Account verification email attempting to send from "noreply@domain" #249

Open
devhawkio opened this issue Dec 15, 2020 · 3 comments
Labels
bug Something isn't working wait for review

Comments

@devhawkio
Copy link

const noReplyEmail = noreply@${domain}`;

	await mail.sendMail({
		from: noReplyEmail,
		to: email,
		subject: "LogChimp - Please confirm your email",
		text: onboardingMailContent.text,
		html: onboardingMailContent.html
	});`

This does not work in the case that domain is localhost. The from address should simply be from the email address that is sending the email. Maybe add a reply-email environment variable to allow an admin to manually change this address, but otherwise nodemailer hits an error.

@devhawkio devhawkio added bug Something isn't working wait for review labels Dec 15, 2020
@mittalyashu
Copy link
Member

@devhawkio

This does not work in the case that domain is localhost.

I am aware of this issue, and looking for a better way to fix it.

The from address should simply be from the email address that is sending the email.

Can you share more information in this?

Maybe add a reply-email environment variable to allow an admin to manually change this address

There are certainly plans in the future to allow using different email address for sending email, which will helpful in sharing updates or announcements.

@devhawkio
Copy link
Author

devhawkio commented Dec 15, 2020 via email

@mittalyashu
Copy link
Member

@devhawkio

That certainly doesn't sound bad, but we planned to put certain limitations on customising sender email to avoid spam/abuse as the other mail services may mark the sender email as spam.

But, as I have said previously, there may be option to choose different user's email under same domain. For example: mike@feedback-site.com, ana@feedback-site.com, noreply@feedback-site.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wait for review
Projects
None yet
Development

No branches or pull requests

2 participants