Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Container Runtime Interface log parser #4742

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add Container Runtime Interface log parser #4742

wants to merge 15 commits into from

Conversation

sydp
Copy link
Contributor

@sydp sydp commented Sep 4, 2023 •
edited by joachimmetz

One line description of pull request

Adds support for the CRI text log format seen in GKE.

Description:

Related issue (if applicable): fixes #4616

Notes:

All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned

@sydp
Copy link
Contributor Author

sydp commented Dec 7, 2023 •
edited

This is dependent on log2timeline/dfdatetime#264 log2timeline/dfdatetime#270

@sydp sydp changed the title [WIP] Add support for CRI-O log format Add CRI-O text log parser Apr 14, 2024
@sydp sydp changed the title Add CRI-O text log parser Add CRI text log parser Apr 14, 2024
@sydp sydp marked this pull request as ready for review April 17, 2024 01:03
@sydp sydp requested a review from joachimmetz April 24, 2024 09:16
@joachimmetz joachimmetz self-assigned this May 2, 2024
@joachimmetz
Copy link
Member

Thanks for the PR, I'll take a look as time permits.

@joachimmetz joachimmetz changed the title Add CRI text log parser Add Container Runtime Interface log parser May 2, 2024
@joachimmetz joachimmetz added this to the 2024 May release milestone May 2, 2024
@joachimmetz
Copy link
Member

CI tests are failing with

======================================================================
FAIL: testProcess (parsers.text_plugins.cri.CRILogTextPluginTest.testProcess)
Tests for the CheckRequiredFormat method.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\plaso\tests\parsers\text_plugins\cri.py", line 23, in testProcess
    self.assertEqual(number_of_event_data, 2)
AssertionError: 12 != 2
----------------------------------------------------------------------

@codecov Codecov
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (e349697) to head (0716dca).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4742      +/-   ##
==========================================
- Coverage   85.21%   85.13%   -0.08%     
==========================================
  Files         428      430       +2     
  Lines       38826    38908      +82     
==========================================
+ Hits        33084    33123      +39     
- Misses       5742     5785      +43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachimmetz joachimmetz joachimmetz left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@joachimmetz joachimmetz

Labels
None yet
Projects
None yet
Milestone
2024 May release
Development

Successfully merging this pull request may close these issues.

Add support for Container Runtime Interface (CRI) log format
2 participants
@sydp @joachimmetz