Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent number of forget samples when evaluating the retain model (forget10 task) #32

Closed
LetheSec opened this issue May 9, 2024 · 2 comments

Comments

@LetheSec
Copy link

LetheSec commented May 9, 2024

Hi, thanks for the great work!

For the forge10 task, the forget set should be 400 samples , as shown in forget10.json . However, there are only 300 samples are used for the evaluation, as shown in eval_log_forget.json.

Can you explain why you do this? Thank you so much.

@zhilif
Copy link
Collaborator

zhilif commented May 19, 2024

In the config file https://github.com/locuslab/tofu/blob/main/config/eval_everything.yaml#L30, we specify the maximum number of samples for evaluation to be 300, for evaluation speed.

@LetheSec
Copy link
Author

Thank you for your reply.

@LetheSec LetheSec reopened this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants