Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt to externalize CFn resource providers #10218

Closed
wants to merge 4 commits into from

Conversation

dominikschubert
Copy link
Member

Motivation

To facilitate external contributions, we'd like to externalize the CloudFormation resource providers into their own repository/lib. The plugin-based providers make this quite easy already, so this is a first attempt at externalized at least a few resource providers.

Changes

TODO

Lots of things still need to happen for this to be productive, e.g.

  • Split resource_providers.py into part that is required for the lib and part that we only need in localstack
  • Better utils for CFn resource providers
  • Extract testing of individual providers at least into providers repo
  • more, TBD

@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Feb 12, 2024
Copy link

github-actions bot commented Feb 12, 2024

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 20s ⏱️
386 tests 336 ✅  50 💤 0 ❌
772 runs  672 ✅ 100 💤 0 ❌

Results for commit a75e349.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 20m 28s ⏱️
2 632 tests 2 383 ✅ 249 💤 0 ❌
2 634 runs  2 383 ✅ 251 💤 0 ❌

Results for commit a75e349.

♻️ This comment has been updated with latest results.

@dominikschubert
Copy link
Member Author

Closing this as we currently don't plan to continue with this for the time being and there's not much here that would be hard to recreate (adding a dependency and aliasing the OperationStatus).

@dominikschubert dominikschubert deleted the externalize-cfn-providers branch May 16, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant