Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged story doesn't appear on /active #1271

Open
pushcx opened this issue Apr 26, 2024 · 2 comments
Open

Merged story doesn't appear on /active #1271

pushcx opened this issue Apr 26, 2024 · 2 comments
Labels
bug good first issue

Comments

@pushcx
Copy link
Member

pushcx commented Apr 26, 2024

In discussion on #300 I realized a story (/s/0qvtim), last comment a few minutes ago, is missing from /active. This is probably a bug with the query in StoryRepository#active.
@pushcx
Copy link
Member Author

pushcx commented Apr 26, 2024 •
edited

Ah, of course, it's the .where("created_at >= ?", 3.days.ago) (it's 5 days old). This is a straight-up design bug, I wanted to have stories with comments in the last 3 days so discussions can bridge the weekends, not stories posted in the last 3 days.

pushcx added a commit that referenced this issue Apr 26, 2024
@pushcx
/active: comments in last 3 days, not stories #1271
3d680c6
@pushcx
Copy link
Member Author

pushcx commented Apr 26, 2024

3d680c6 is only a partial fix. It should include comments on stories merged in. That query is a little more finicky than I can bang out right now, so this bug is available anyone wants to take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pushcx