You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We’re on a years-old version of CommonMarker. It’s changed its API, dropping a method we used in extras/markdowner.rb to add attributes to links, rewrite some HTML, and make the @username feature work. (Heck, they even renamed their constant from CommonMarker to Commonmarker.)
That issue links to a gem they suggest, but perhaps we should just expand our use of Nokogiri? Or maybe there’s a very different way to tie into the renderer at the time it’s emitting HTML, which I’d be more confident in than re-parsing and fixing things up externally. So this one requires some technical investigation!
The text was updated successfully, but these errors were encountered:
We’re on a years-old version of CommonMarker. It’s changed its API, dropping a method we used in
extras/markdowner.rb
to add attributes to links, rewrite some HTML, and make the@username
feature work. (Heck, they even renamed their constant fromCommonMarker
toCommonmarker
.)That issue links to a gem they suggest, but perhaps we should just expand our use of Nokogiri? Or maybe there’s a very different way to tie into the renderer at the time it’s emitting HTML, which I’d be more confident in than re-parsing and fixing things up externally. So this one requires some technical investigation!
The text was updated successfully, but these errors were encountered: