Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate docker build with GitHub actions #59

Open
figassis opened this issue Jan 17, 2021 · 9 comments
Open

Automate docker build with GitHub actions #59

figassis opened this issue Jan 17, 2021 · 9 comments

Comments

@figassis
Copy link

Hooks aren't available in the stable release, but readme makes no mention that they are only in the experimental / latest tag.

@figassis figassis changed the title Hooks aren't available in 1.2-0.9.4, but documentation implies that it is. Hooks aren't available in any version, but are shown in documentation Jan 18, 2021
@niondir
Copy link
Member

niondir commented Jan 19, 2021

Hey, thanks for mentioning. Feel free to add some clarification to the readme. In general the readme is always according to the current commig (e.g. master) which rarely is the latest release. So it's common in github.

@vintzvintz
Copy link

As of today, the latest image on dockerhub is not up to date with the git repo ( late by 18 commits )
Hooks were added and documented in README recently.
So you have two solutions :

  • build your own image from the git repo
  • wait a new image is pushed on dockerhub by the author

@figassis
Copy link
Author

@niondir
Copy link
Member

niondir commented Apr 7, 2021

I have issues setting up docker hub to always build an up to date container. I need to spend some time on it or build it with our company CI in future :)

@dunklesToast
Copy link

If you need help pushing a Docker Container from GitHub Actions to DockerHub I could help you.

@niondir
Copy link
Member

niondir commented Aug 2, 2023

@dunklesToast I know it's a late reply but adding GitHub actions based build would be a Great addition.
PR is welcome. I would then take care about adding the right credentials for my dockerhub account.

@niondir niondir changed the title Hooks aren't available in any version, but are shown in documentation Automate docker build with GitHub actions Aug 3, 2023
@niondir
Copy link
Member

niondir commented Aug 5, 2023

Done: https://github.com/lobaro/restic-backup-docker/pkgs/container/restic-backup-docker

Might need some further updates, it just worked with the github template :)

@niondir niondir closed this as completed Aug 5, 2023
@dunklesToast
Copy link

@niondir looks great! only thing i'd probably add would be a timeout so if the action stalls for some reason it will be terminated after a specified period of time and won't burn useless ci minutes.
You can read more here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

@niondir
Copy link
Member

niondir commented Aug 6, 2023

Sounds reasonable, can you just add it?
Else I will have a look some time.

I also noted that the config already contains some deprecated stuff.
And the semantic versioning approach (adding a +restic 0-16-0) fails because docker does not support the plus character in tags... Something I already found somewhere else.

@niondir niondir reopened this Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants