Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Adding removed node back to cluster #350

Open
antmat opened this issue Apr 1, 2024 · 1 comment
Open

[Question] Adding removed node back to cluster #350

antmat opened this issue Apr 1, 2024 · 1 comment

Comments

@antmat
Copy link

antmat commented Apr 1, 2024

Hi!
We are trying to use dragonboat and we have usecase when node is being removed from the cluster, cleared and after some time plugged back to the cluster. Dragonboat states that "Requesting a removed node back to the Raft cluster will always be rejected.", however we wanted to map our own unique entity one to one to nodeID. In this case it would still be the same and nodeID addition will be rejected.
Can you please explain what is the reason for this limitation in case we start a fresh node with the same ID?
Thanks in advance

@kevburnsjr
Copy link
Contributor

Seems to me like disallowing the reuse of node IDs just simplifies the protocol and implementation by not having to keep track of extra metadata. If you did want to support node ID reuse, you would have to keep track of a sort of node generation ID in order to allow a node to correctly transition from a closed state to an open state.

This maybe makes more sense in v4 terminology where nodes are called replicas. If you remove a replica from the shard and try to add it back, you have to pull a fresh snapshot and are thus creating a new replica which is a standard procedure. Best to just march forward with your replica IDs and not try to assign them any special meaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants