Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LogReader from public API #318

Open
lni opened this issue Jun 28, 2023 · 0 comments
Open

Remove LogReader from public API #318

lni opened this issue Jun 28, 2023 · 0 comments
Assignees

Comments

@lni
Copy link
Owner

lni commented Jun 28, 2023

LogReader will be removed from the v4 public API.

If you need to somehow get repeated or random access to some log entries, you can always sequentially record all those log entries whenever your Update method is called. You can then have full control of the copy you maintain.

Dragonboat's internal log is private, not exposing it is the best way to prevent surprises like #315, this also gives dragonboat more flexibility on when to do the compaction.

@lni lni self-assigned this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant