Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is a feature to skip the short length? i mean the length can custom for 7-30 characters only and skip 1-6 characters #19

Open
adityaerlangga opened this issue Dec 18, 2022 · 4 comments · May be fixed by #30

Comments

@adityaerlangga
Copy link

No description provided.

@0xCaponte
Copy link
Contributor

Today I had a random idea on how to do this and tried to implement it. However, given the way the permutations are generated my "enhancement" ended up being just ignoring them if they are shorter than the min value. I dont see any significant improvement when working with small secrets, and I am currently unable to test with something longer.

@lmammino if you want, create a new branch for this issue and I will make a PR to it so you can have a look.

@lmammino
Copy link
Owner

This feature does not exist at the moment, but I agree it would make a lot of sense. Happy to receive any PRs for it :)

@0xCaponte
Copy link
Contributor

I have it "ready" but as I am not sure if it really brings any performance improvement, I dont want to make a PR to the main branch. Is it possible that you set-up another branch so I make the PR there and you can have a look?

@lmammino
Copy link
Owner

You can open a PR against the main branch anyway, then we can review it and decide whether to merge it or not (or keep it in another branch by retargeting the PR)...

@lmammino lmammino linked a pull request Jun 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants