Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<group layout=horizontal> does not work for images #48

Open
glop102 opened this issue Dec 2, 2021 · 0 comments
Open

<group layout=horizontal> does not work for images #48

glop102 opened this issue Dec 2, 2021 · 0 comments

Comments

@glop102
Copy link

glop102 commented Dec 2, 2021 •
edited

When attempting to put two small images next to each other with a horizontal layout, it instead skips the images instead of even displaying them vertically. This is confusing to an end user who will think something is not working with how they are attempting to use the extension. It would be better to attempt to show an image even if the formatting breaks a bit.

<infobox>
<group layout="horizontal">
   <image source="imageface"/>
   <image source="imagesprite"/>
</group>
</infobox>
glop102 pushed a commit to glop102/mediawiki-PortableInfobox that referenced this issue Dec 2, 2021
Display images when group layout is horizontal
00b5056 
Remove the restriction to only show data nodes in a horizontal layout.
Instead have it special case headers only, and then generically attempt
to use a pre-rendered 'value' that data nodes have or ask for the node
to be rendered to be displayed.

Should handle issue lkucharczyk#48
@glop102 glop102 mentioned this issue Dec 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glop102