Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net: Allow to exclude this functionality at compile time #315

Open
solardiz opened this issue Feb 25, 2024 · 1 comment
Open

Net: Allow to exclude this functionality at compile time #315

solardiz opened this issue Feb 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@solardiz
Copy link
Contributor

Nov 28, 2022

This is now implemented as LKRG_WITH_NET defined in net.h.

I suggest we use the LKRG_WITH_* naming for these things, and we might later move them all e.g. to a config.h file.

While at it, I found that disabling of our P_LKRG_UNHIDE (to be renamed to LKRG_WITH_UNHIDE later) does something weird: #251

@solardiz
Copy link
Contributor Author

The remaining task here, if any, may be to wrap or move this setting into a documented make command-line knob or into a new config.h file. We could also reconsider the default - having this compiled in was good during development at least to get more testing from GitHub Actions, but do we want this included in most LKRG builds or not?

@solardiz solardiz added the enhancement New feature or request label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant