Move alias check before custom handler check #1515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
- Coverage 57.08% 57.04% -0.05%
==========================================
Files 60 60
Lines 2123 2123
==========================================
- Hits 1212 1211 -1
- Misses 911 912 +1 |
|
Hmm.. do you have any guidance on why the coverage results changed? |
See #1489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move alias check before custom handler check.
Checklist
I have read contributing guidelines
I'm sure that I did not unrelated changes in this pull request
I have created at least one test case for the changes I have made
I have added myself to the CONTRIBUTORS.rst
I have added my changes to the CHANGELOG.rst
Related issues
Closes #1514