[Fix] ES5+: Use spec‑accurate IsCallable
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
reviewed
May 16, 2020
| module.exports = require('is-callable'); | ||
| module.exports = function IsCallable(argument) { | ||
| // some older engines say that typeof /abc/ === 'function', | ||
| return typeof argument === 'function' |
There was a problem hiding this comment.
this isn't actually useful though, because it will report class constructors as callable.
There was a problem hiding this comment.
Well, that’s what the specification for IsCallable says to do.
ljharb
reviewed
May 17, 2020
ExE-Boss
force-pushed
the
fix/es5/use-spec-accurate-iscallable-isconstructor-implementation
branch
from
cbdd330
to
371fc87
Compare
ExE-Boss
force-pushed
the
fix/es5/use-spec-accurate-iscallable-isconstructor-implementation
branch
from
371fc87
to
c617543
Compare
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 90.90% 91.00% +0.09%
==========================================
Files 647 647
Lines 8961 9071 +110
Branches 2120 2137 +17
==========================================
+ Hits 8146 8255 +109
- Misses 815 816 +1
Continue to review full report at Codecov.
|
ljharb
force-pushed
the
fix/es5/use-spec-accurate-iscallable-isconstructor-implementation
branch
from
c617543
to
a0dc7e0
Compare
|
I've separated out the IsConstructor fixes and pulled those into master; this PR has been rebased with just the IsCallable changes. |
ljharb
changed the title
ES5+: Use spec‑accurate IsCallable and IsConstructor implsES5+: Use spec‑accurate IsCallable
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IsConstructorimplementation is based on the one in tc39/ecma262#1798 (comment)Fixes #48