Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor type error in Awareness.states #1436

Open
jsonkao opened this issue Jan 29, 2024 · 0 comments
Open

Minor type error in Awareness.states #1436

jsonkao opened this issue Jan 29, 2024 · 0 comments
Labels
documentation Related to the public documentation text collaboration

Comments

@jsonkao
Copy link

jsonkao commented Jan 29, 2024

What is the improvement or update you wish to see?

When using a LiveblocksProvider's awareness in a yjs plugin (yCursorPlugin from y-prosemirror), I get the following type error:

image

Is there any context that might help us understand?

Would require changing the type declaration at https://github.com/liveblocks/liveblocks/blob/main/packages/liveblocks-yjs/src/awareness.ts

@jsonkao jsonkao added documentation Related to the public documentation enhancement New feature or request triage needed The issue needs to be reviewed by the team labels Jan 29, 2024
@adigau adigau added the public repo label Apr 15, 2024 — with Linear
@adigau adigau added text collaboration and removed triage needed The issue needs to be reviewed by the team enhancement New feature or request public repo labels Apr 15, 2024
@adigau adigau added the 🖋️ Text label Apr 24, 2024 — with Linear
@adigau adigau added the Engineering label May 9, 2024 — with Linear
@adigau adigau removed the Engineering label May 9, 2024
@adigau adigau added the Engineering label May 9, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to the public documentation text collaboration
Projects
None yet
Development

No branches or pull requests

2 participants