Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborative Cursors + Selected text Flicker for Tiptap + YJS #1161

Open
YassineRjl opened this issue Sep 28, 2023 · 3 comments
Open

Collaborative Cursors + Selected text Flicker for Tiptap + YJS #1161

YassineRjl opened this issue Sep 28, 2023 · 3 comments
Labels
bug Something isn't working triage needed The issue needs to be reviewed by the team

Comments

@YassineRjl
Copy link

YassineRjl commented Sep 28, 2023

Describe the bug

I noticed the carets for remote users flicker when the editor (TipTap) is focused. Please check the recording.

To Reproduce

Steps to reproduce the behavior:

  1. Run https://github.com/liveblocks/liveblocks/tree/main/examples/nextjs-yjs-tiptap-advanced

Note: I tried with npm 10.1.0

Expected behavior

The remote cursors + selections don't flicker.

Illustrations

Liveblocks.bug.1.mov

Environment (please complete the following information):

  • Chrome 116.0.5845.187 (Official Build) (arm64)
@YassineRjl YassineRjl added bug Something isn't working triage needed The issue needs to be reviewed by the team labels Sep 28, 2023
@YassineRjl
Copy link
Author

Update: I tried with the TipTap provider, and it still flickered.

But, it's now working as expected on both NextJs & ReactJs after building and serving the static files. For some reason running "yarn start" for react or "yarn dev" for nextjs gets the cursor to flicker. So yeah just build and start

@CTNicholas
Copy link
Contributor

CTNicholas commented Sep 28, 2023

Thanks for letting us know! We've been looking into this one already https://github.com/liveblocks/liveblocks.io/issues/1552. I think it could be a problem with the CollaborationCursor plugin. I'll make a bug report.

@CTNicholas
Copy link
Contributor

CTNicholas commented Sep 28, 2023

It's already been reported! ueberdosis/tiptap#4482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage needed The issue needs to be reviewed by the team
Projects
None yet
Development

No branches or pull requests

2 participants