Fix fast LiveList.insert + LiveList.set bug #1002
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeSalles
commented
Jul 14, 2023
| @@ -870,7 +892,7 @@ export class LiveList<TItem extends Lson> extends AbstractCrdt { | |||
| this._pool?.assertStorageIsWritable(); | |||
| if (index < 0 || index > this._items.length) { | |||
| throw new Error( | |||
| `Cannot insert list item at index " ${index}". index should be between 0 and ${this._items.length}` | |||
| `Cannot insert list item at index "${index}". index should be between 0 and ${this._items.length}` | |||
There was a problem hiding this comment.
These error messages included some invisible characters between " and $
GuillaumeSalles
commented
Jul 14, 2023
| ]); | ||
|
|
||
| expectStorage({ | ||
| items: ["B"], |
There was a problem hiding this comment.
Before the fix, items were equal to ["A","B"] here.
…ledgedDeletedIds fix
…locks into livelist-insert-set-bug
This was
linked to
issues
Aug 17, 2023
|
Hi @GuillaumeSalles, we believe that we're hitting the error that this PR intends to fix. Do you know when we should expect more update here? We're happy to help test out the fix if you can publish an updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that insert acknowledge op is ignored if the item has been deleted by a local
LiveList.set.I took the opportunity to add comments and do some cleanups.
Before merging this, we need to make sure e2e tests are passing on public and private repositories. (We might need to fix our tests setup to work with ESM)
Review commit by commit recommended
How to test it
Upgrade our block based editor example to use
1.2.2-test3and try to reproduce the behavior described in #731. This should also fix the "ghosting bug" mentioned by Fermat and Arcol.Related issue(s)
setresults in delete/insert events #628